Fixes to cmake config generation #2448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgritz
force-pushed
the
lg-cmakecleanup
branch
from
6111ca5
to
b06094c
Compare
* Relax version compatibility specification to just matching major version. * Specify targets cmake name correctly. * Make sure install include dir is listed in the public include dirs of the libraries. * Some other cleanup and genericization. I believe this corrects some deficiencies in the generated OpenImageIOConfig.cmake that projects can use that exclusively (with imported targets) and have no need for a copy of FindOpenImageIO.cmake. Unless objections are raised, I will also backport this to 2.1 for the patch release that's coming in a few days.
lgritz
force-pushed
the
lg-cmakecleanup
branch
from
b06094c
to
7900cda
Compare
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Jan 2, 2020
* Relax version compatibility specification to just matching major version. * Specify targets cmake name correctly. * Make sure install include dir is listed in the public include dirs of the libraries. * Some other cleanup and genericization. I believe this corrects some deficiencies in the generated OpenImageIOConfig.cmake that projects can use that exclusively (with imported targets) and have no need for a copy of FindOpenImageIO.cmake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libraries.
I believe this corrects some deficiencies in the generated OpenImageIOConfig.cmake that projects can use that exclusively (with imported targets) and have no need for a copy of FindOpenImageIO.cmake.
Unless objections are raised, I will also backport this to 2.1 for the patch release that's coming in a few days.