Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address strict warnings about unused parameters to functions #2464

Merged
merged 3 commits into from
Jan 22, 2020

Conversation

lgritz
Copy link
Collaborator

@lgritz lgritz commented Jan 18, 2020

Fool around with -Wextra (optional, off by default for now), see what
turns up.

No code changes in this batch -- just suppress warnings by commenting
out param names for functions where they are not used (often because
they are base class stubs and the like). For functions that are part
of the public API where we use Doxygen to extract the declarations, we
can't comment out the param names, so instead mark them with
OIIO_MAYBE_UNUSED (and tell Doxygen to make that word go away in the
docs).

Fool around with -Wextra (optional, off by default for now), see what
turns up.

No code changes in this batch -- just suppress warnings by commenting
out param names for functions where they are not used (often because
they are base class stubs and the like). For functions that are part
of the public API where we use Doxygen to extract the declarations, we
can't comment out the param names, so instead mark them with
OIIO_MAYBE_UNUSED (and tell Doxygen to make that word go away in the
docs).
@lgritz lgritz merged commit 95ac64f into AcademySoftwareFoundation:master Jan 22, 2020
@lgritz lgritz deleted the lg-warn1 branch January 22, 2020 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant