Fixes related to unused parameters. #2465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More exploring what -Wextra turns up. Found several buglets! * The string version of getsym didn't pass along report_error. * ImageBuf::getchannel did not honor its wrap parameter. * ImageSpec::erase_attribute did not honor its 'searchtype' parameter. * IBA::reorient did not pass its nthreads params to its children. * IBA::computePixelHashSHA1 did not honor its nthreads parameter. * Get rid of useless parameter in internal helper function parse_elements.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Jan 22, 2020
More exploring what -Wextra turns up. Found several buglets! * The string version of getsym didn't pass along report_error. * ImageBuf::getchannel did not honor its wrap parameter. * ImageSpec::erase_attribute did not honor its 'searchtype' parameter. * IBA::reorient did not pass its nthreads params to its children. * IBA::computePixelHashSHA1 did not honor its nthreads parameter. * Get rid of useless parameter in internal helper function parse_elements.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Jan 23, 2020
More exploring what -Wextra turns up. Found several buglets! * The string version of getsym didn't pass along report_error. * ImageBuf::getchannel did not honor its wrap parameter. * ImageSpec::erase_attribute did not honor its 'searchtype' parameter. * IBA::reorient did not pass its nthreads params to its children. * IBA::computePixelHashSHA1 did not honor its nthreads parameter. * Get rid of useless parameter in internal helper function parse_elements.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Feb 5, 2020
More exploring what -Wextra turns up. Found several buglets! * The string version of getsym didn't pass along report_error. * ImageBuf::getchannel did not honor its wrap parameter. * ImageSpec::erase_attribute did not honor its 'searchtype' parameter. * IBA::reorient did not pass its nthreads params to its children. * IBA::computePixelHashSHA1 did not honor its nthreads parameter. * Get rid of useless parameter in internal helper function parse_elements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More exploring what -Wextra turns up.
Found several buglets!
The string version of getsym didn't pass along report_error.
ImageBuf::getchannel did not honor its wrap parameter.
ImageSpec::erase_attribute did not honor its 'searchtype' parameter.
IBA::reorient did not pass its nthreads params to its children.
IBA::computePixelHashSHA1 did not honor its nthreads parameter.
Get rid of useless parameter in internal helper function parse_elements.