More fixes for problems found by -Wextra #2475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More actual (unreported) buglets revealed by -Wextra pointing out function parameters that were unused. * Failed to properly swap endianness when decoding Canon camera info. * ColorProcessor::apply methods were not using chanstride param. * texture3d fixes: some deriv results dropped on the floor * Get rid of unused parameters in some internal functions. Not a bug per se, but could be misleading about how the functions operate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More actual (unreported) buglets revealed by -Wextra pointing out function
parameters that were unused.
Failed to properly swap endianness when decoding Canon camera info.
ColorProcessor::apply methods were not using chanstride param.
texture3d fixes: some deriv results dropped on the floor
Get rid of unused parameters in some internal functions. Not a bug
per se, but could be misleading about how the functions operate.