Rewrite of clamp() from Alex Wells generates 2x faster code. #2491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add clamp unit test and benchmark, and the previously missing implementation of clamp for vfloat16.
|
LGTM. Should the unit test check NAN returns the low value (as that is a feature/requirement)? |
|
That unit test has existed all along. Its failure with the first implementation you suggested is how the NaN issue came to my attention. |
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Feb 26, 2020
…SoftwareFoundation#2491) Also add clamp unit test and benchmark, and the previously missing implementation of clamp for vfloat16.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add clamp unit test and benchmark, and the previously missing
implementation of clamp for vfloat16.