Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix oiiotool --autotrim to use all subimages #2497

Merged
merged 1 commit into from
Feb 27, 2020

Conversation

lgritz
Copy link
Collaborator

@lgritz lgritz commented Feb 25, 2020

Previously, --autotrim when applied to a multi-subimage file would trim
all subimages to the nonzero region of just the first subimage.

This fixes, now examining all subimages and trimming them all to the
union of their nonzero regions (as --trim always did).

Technically, a multi-part OpenEXR can trim each subimage ("part")
separately, each having a different data window. But in practice, many
reading applications (including RV and Nuke!) seem to have trouble
reading files like that. So we go with the union approch.

Previously, --autotrim when applied to a multi-subimage file would trim
all subimages to the nonzero region of just the first subimage.

This fixes, now examining all subimages and trimming them all to the
union of their nonzero regions (as --trim always did).

Technically, a multi-part OpenEXR can trim each subimage ("part")
separately, each having a different data window. But in practice, many
reading applications (including RV and Nuke!) seem to have trouble
reading files like that. So we go with the union approch.
@lgritz lgritz merged commit a81c0f1 into AcademySoftwareFoundation:master Feb 27, 2020
@lgritz lgritz deleted the lg-trim branch February 27, 2020 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant