Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FindOpenEXR.cmake: Add detection of debug builds #2505

Merged
merged 1 commit into from
Mar 3, 2020
Merged

FindOpenEXR.cmake: Add detection of debug builds #2505

merged 1 commit into from
Mar 3, 2020

Conversation

Shootfast
Copy link
Contributor

Description

Debug builds of OpenEXR have an _d suffix (on Windows at least). This patch adds these file names to the searched library names.

Tests

Built the code on Windows and linked against both Release and Debug builds of OpenEXR 2.4.1

Checklist:

  • I have read the contribution guidelines.
  • If this is more extensive than a small change to existing code, I
    have previously submitted a Contributor License Agreement
    (individual, and if there is any way my
    employers might think my programming belongs to them, then also
    corporate).
  • I have updated the documentation, if applicable.
  • I have ensured that the change is tested somewhere in the testsuite
    (adding new test cases if necessary).
  • My code follows the prevailing code style of this project.

Debug builds of OpenEXR have an _d suffix (on Windows at least). This patch adds these file names to the searched library names.
@lgritz lgritz merged commit 5a796bb into AcademySoftwareFoundation:master Mar 3, 2020
@Shootfast Shootfast deleted the patch-1 branch March 4, 2020 12:42
lgritz pushed a commit to lgritz/OpenImageIO that referenced this pull request Mar 7, 2020
…dation#2505)

Debug builds of OpenEXR have an _d suffix (on Windows at least). This patch adds these file names to the searched library names.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants