unordered_map_concurrent: fix missing size decrement upon erase #2624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Larry Gritz <lg@larrygritz.com>
|
Did you benchmark this? Any reason to think this might influence the texture system? |
I reviewed the places in OIIO which use this class, it does not affect the correctness of OIIO's texture system itself. However, we re-used OIIO's infrastructure to build some other cache system, which requires this class to be correctly implemented. |
|
It only fixes the fact that as we called erase(), it was not decrementing the overall count of entries in the map (which we were incrementing when we add entries). In our code base, there are no consequences, which is why we never noticed the bug. |
fpsunflower
approved these changes
Jul 2, 2020
|
LGTM then! |
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Jul 4, 2020
…emySoftwareFoundation#2624) Signed-off-by: Larry Gritz <lg@larrygritz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2623
Signed-off-by: Larry Gritz lg@larrygritz.com