oiiotool: Fix --eraseattrib not applying to all subimages #2632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Either -a or optional modifier :allsubimages=1 ought to have erased an attribute from all subimages, but it was erased from only the first. Add a test to verify that --attrib and --eraseattrib both apply correctly to all subimages when requested. Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
added a commit
that referenced
this pull request
Jul 7, 2020
Either -a or optional modifier :allsubimages=1 ought to have erased an attribute from all subimages, but it was erased from only the first. Add a test to verify that --attrib and --eraseattrib both apply correctly to all subimages when requested. Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Jul 7, 2020
…twareFoundation#2632) Either -a or optional modifier :allsubimages=1 ought to have erased an attribute from all subimages, but it was erased from only the first. Add a test to verify that --attrib and --eraseattrib both apply correctly to all subimages when requested. Signed-off-by: Larry Gritz <lg@larrygritz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Either -a or optional modifier :allsubimages=1 ought to have erased
an attribute from all subimages, but it was erased from only the first.
Add a test to verify that --attrib and --eraseattrib both apply
correctly to all subimages when requested.
Signed-off-by: Larry Gritz lg@larrygritz.com