Fix build break due to pybind11 master recent change #2637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using the explicit `cast<TypeDesc>()` instead of allowing the template system to figure it out, we were losing the `const` detection and making it fail to match templates. It used to work, but a recently added change in pybind11's master branch caused this to finally fail. Also change the "latest releases" to use pybind11 2.5. (Only semi-related, 2.5 was fine, it was post-2.5 where we broke.) Signed-off-by: Larry Gritz <lg@larrygritz.com>
fpsunflower
approved these changes
Jul 8, 2020
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Jul 8, 2020
…Foundation#2637) By using the explicit `cast<TypeDesc>()` instead of allowing the template system to figure it out, we were losing the `const` detection and making it fail to match templates. It used to work, but a recently added change in pybind11's master branch caused this to finally fail. Also change the "latest releases" to use pybind11 2.5. (Only semi-related, 2.5 was fine, it was post-2.5 where we broke.) Signed-off-by: Larry Gritz <lg@larrygritz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using the explicit
cast<TypeDesc>()instead of allowing thetemplate system to figure it out, we were losing the
constdetectionand making it fail to match templates. It used to work, but a recently
added change in pybind11's master branch caused this to finally fail.
Also change the "latest releases" to use pybind11 2.5. (Only semi-related,
2.5 was fine, it was post-2.5 where we broke.)
Signed-off-by: Larry Gritz lg@larrygritz.com