Fix poor performance with texture cache and HDR files #2662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the texture cache reads scanlines in random order, the same pixels could be read many times over. Now the file offset for scanlines is cached for quick random access.
|
That's awesome! |
lgritz
approved these changes
Aug 6, 2020
|
How far back would you like this backported, @brechtvl ? Obvs 2.2. Do you want a 2.1 backport also, considering that 2.2 will be the supported release at the end of the month? |
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Aug 6, 2020
…eFoundation#2662) When the texture cache reads scanlines in random order, the same pixels could be read many times over. Now the file offset for scanlines is cached for quick random access.
|
We don't need a backport to 2.1 then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the texture cache reads scanlines in random order, the same pixels could
be read many times over. Now the file offset for scanlines is cached for quick
random access.
Example command that is 18x faster here with this change:
Tests
I'm not aware of an existing mechanism to test such performance issues.
Checklist:
have previously submitted a Contributor License Agreement
(individual, and if there is any way my
employers might think my programming belongs to them, then also
corporate).
(adding new test cases if necessary).