TIFF: Fix spec() and spec_dimensions() for mipmapped tiff files #2723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For "mip-mapped" TIFF files where we use the multiple images in the file to emulate MIP-maps rather than what we ordinarily consider subimages, a call to `ImageInput::spec(subimage,miplevel)` was not properly recognizing invalid subimage values and returning an empty ImageSpec as advertised. Basically, we assumed that they would only ask for a valid subimage and miplevel and didn't properly handle out of range values. Same problem for spec_dimensions(). Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Sep 26, 2020
…emySoftwareFoundation#2723) For "mip-mapped" TIFF files where we use the multiple images in the file to emulate MIP-maps rather than what we ordinarily consider subimages, a call to `ImageInput::spec(subimage,miplevel)` was not properly recognizing invalid subimage values and returning an empty ImageSpec as advertised. Basically, we assumed that they would only ask for a valid subimage and miplevel and didn't properly handle out of range values. Same problem for spec_dimensions(). Signed-off-by: Larry Gritz <lg@larrygritz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For "mip-mapped" TIFF files where we use the multiple images in the file
to emulate MIP-maps rather than what we ordinarily consider subimages,
a call to
ImageInput::spec(subimage,miplevel)was not properlyrecognizing invalid subimage values and returning an empty ImageSpec
as advertised. Basically, we assumed that they would only ask for a
valid subimage and miplevel and didn't properly handle out of range
values.
Same problem for spec_dimensions().
Fixes #2719
Signed-off-by: Larry Gritz lg@larrygritz.com