pugixml build fixes #2733
Merged
pugixml build fixes #2733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Solves the warning for me! |
lgritz
force-pushed
the
lg-pugixml-ghci
branch
2 times, most recently
from
a97d293
to
2523c10
Compare
* Bring back the idea of a Findpugixml.cmake file because it turns out that (for pugixml <= 1.10) the exported config files are not reliable. * Fix CI scripts to build PugiXML (with a few different versions). We previously were relying on the embedded version for all CI tests, which masked problems associated with using an external PugiXML. * Fix deprecation warnings about xml_document.load(), the new call is xml_document::load_string(). Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
force-pushed
the
lg-pugixml-ghci
branch
from
2523c10
to
d5f48f4
Compare
|
Confirming that this let me build it with system pugixml and it linked correctly ❤️ Thanks a lot! |
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Oct 12, 2020
* Bring back the idea of a Findpugixml.cmake file because it turns out that (for pugixml <= 1.10) the exported config files are not reliable. * Fix CI scripts to build PugiXML (with a few different versions). We previously were relying on the embedded version for all CI tests, which masked problems associated with using an external PugiXML. * Fix deprecation warnings about xml_document.load(), the new call is xml_document::load_string(). Signed-off-by: Larry Gritz <lg@larrygritz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring back the idea of a Findpugixml.cmake file because it turns out
that (for pugixml <= 1.10) the exported config files are not reliable.
Fix CI scripts to build PugiXML (with a few different versions). We
previously were relying on the embedded version for all CI tests, which
masked problems associated with using an external PugiXML.
Fix deprecation warnings about xml_document::load(), the new call is
xml_document::load_string().
Fixes #2732
Signed-off-by: Larry Gritz lg@larrygritz.com