StrongParam helper for disambiguating parameters #2735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Larry Gritz <lg@larrygritz.com>
|
Does anybody have thoughts, pro or con, about this kind of idiom to clarify parameter passing in some cases? |
|
I've sat on this for a long time, but I'm going to merge now because I just had to fix a really embarrassing bug that would not have happened if I'd used this idiom: #2844 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider this a design review. The point is all explained in depth in the comments, I won't restate it here.
This is an idea I've been contemplating for a long time. I want people to think about whether using this idiom -- sparingly, in the kinds of places where we may have used an enum to bring more clarity than a bare bool or int -- would help improve code readability and reduce parameter passing errors. If so, I'd like to start using it. But if people think it's a needless flourish that detracts from code readability, then I can be persuaded to abandon it.
Signed-off-by: Larry Gritz lg@larrygritz.com