Add support for saving progressive jpegs #2749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgritz
reviewed
Oct 22, 2020
src/jpeg.imageio/jpegoutput.cpp
Outdated
Comment on lines
189
to
190
| ParamValue* progressive = m_spec.find_attribute("jpeg:progressive", TypeDesc::INT); | ||
| if (progressive && *(int*)progressive->data() != 0) { |
There was a problem hiding this comment.
There's a new idiom that is a more compact way to express this!
if (m_spec.get_int_attribute("jpeg:progressive")) {
(The value it returns if the attrib doesn't exist is 0, so this works out perfectly in this case. Though you can also pass a second argument that is the default to use if there is no attribute.)
Or, since 2.1, this also works (which style you prefer might perhaps be a matter of personal taste):
if (m_spec["jpeg:progressive"].get<int>()) {
There was a problem hiding this comment.
Nice, thank you. I went with the first option as it looks a little cleaner to me.
lgritz
approved these changes
Oct 22, 2020
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows saving progressive jpegs by adding the attribute "jpeg:progressive", an int which if non-zero will tell libjpeg to create a progressive file.
Tests
TODO
Checklist:
have previously submitted a Contributor License Agreement
(individual, and if there is any way my
employers might think my programming belongs to them, then also
corporate).
(adding new test cases if necessary).