Windows CI fixes #2796
Merged
Windows CI fixes #2796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgritz
approved these changes
Dec 28, 2020
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Jan 4, 2021
* fixes to make vs2019 CI run. Not passing yet as some tests fail * added explicit ctest timeout (180sec) + misc fixes to run CI local * disable Windows VS2019 tests again as they are not passing yet Co-authored-by: Dieter De Baets <dieter.baets@unity3d.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes some issues found when trying to enable CI on Windows.
With these fixes, the Windows CI is running yet only about 70% of the tests pass.
Note that this PR does not enable CI nor fixes the failing tests.
I created issue #2797 to keep track of the failing tests.
Once all tests are stable, we can enable the CI for Windows.
Tests
Any existing CI is still running/passing.
Checklist:
have previously submitted a Contributor License Agreement
(individual, and if there is any way my
employers might think my programming belongs to them, then also
corporate).
(adding new test cases if necessary).