New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabled AVIF decoding with libheif #2811
Conversation
Requires libheif built with libaom or dav1d/rav1e
Requires libheif built with libaom or dav1d/rav1e Add a test file and simple test for AVIF
Requires libheif built with libaom or dav1d/rav1e
…cademySoftwareFoundation#2812) Requires libheif built with libaom or dav1d/rav1e
@hjmallon You were totally correct with the failureok trick that I asked you to remove. I realize now that I was confused, thinking that you were marking the entire test as "ok to fail" (and thus meaningless), but in fact I had forgotten that what that flag actually indicates is that it's ok for any individual command within the test to exit with an error return code, but the test overall will pass or fail based on whether the outputs matched any of the available references. So sorry to have steered you wrong. Would you mind restoring what you were originally trying to do with the test, so that the heif test will pass whether or not the avif support is enabled (as long as the output matches either the "heic+avif" or "heic only" reference outputs)? |
See #2818 |
Description
Requires libheif built with libaom or dav1d/rav1e. Changes to the code just required adding '.avif' to the extensions.
Also updated as much of the docs as I could find to mention AVIF.
Tests
I have added a testsuite file, but it only uses the info command like the other heic file.
Checklist:
have previously submitted a Contributor License Agreement
(individual, and if there is any way my
employers might think my programming belongs to them, then also
corporate).
(adding new test cases if necessary).