Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled AVIF decoding with libheif #2811

Merged
merged 2 commits into from Jan 4, 2021

Conversation

hjmallon
Copy link
Contributor

@hjmallon hjmallon commented Jan 4, 2021

Description

Requires libheif built with libaom or dav1d/rav1e. Changes to the code just required adding '.avif' to the extensions.

Also updated as much of the docs as I could find to mention AVIF.

Tests

I have added a testsuite file, but it only uses the info command like the other heic file.

Checklist:

  • I have read the contribution guidelines.
  • If this is more extensive than a small change to existing code, I
    have previously submitted a Contributor License Agreement
    (individual, and if there is any way my
    employers might think my programming belongs to them, then also
    corporate).
  • I have updated the documentation, if applicable.
  • I have ensured that the change is tested somewhere in the testsuite
    (adding new test cases if necessary).
  • My code follows the prevailing code style of this project.

INSTALL.md Outdated Show resolved Hide resolved
src/cmake/externalpackages.cmake Outdated Show resolved Hide resolved
src/doc/builtinplugins.rst Show resolved Hide resolved
testsuite/heif/run.py Outdated Show resolved Hide resolved
@lgritz lgritz merged commit 5dda98c into AcademySoftwareFoundation:master Jan 4, 2021
lgritz pushed a commit to lgritz/OpenImageIO that referenced this pull request Jan 5, 2021
Requires libheif built with libaom or dav1d/rav1e

Add a test file and simple test for AVIF
hjmallon added a commit to hjmallon/oiio that referenced this pull request Jan 5, 2021
Requires libheif built with libaom or dav1d/rav1e
lgritz pushed a commit that referenced this pull request Jan 5, 2021
Requires libheif built with libaom or dav1d/rav1e
lgritz pushed a commit to lgritz/OpenImageIO that referenced this pull request Jan 5, 2021
@lgritz
Copy link
Collaborator

lgritz commented Jan 6, 2021

@hjmallon You were totally correct with the failureok trick that I asked you to remove. I realize now that I was confused, thinking that you were marking the entire test as "ok to fail" (and thus meaningless), but in fact I had forgotten that what that flag actually indicates is that it's ok for any individual command within the test to exit with an error return code, but the test overall will pass or fail based on whether the outputs matched any of the available references.

So sorry to have steered you wrong.

Would you mind restoring what you were originally trying to do with the test, so that the heif test will pass whether or not the avif support is enabled (as long as the output matches either the "heic+avif" or "heic only" reference outputs)?

@hjmallon
Copy link
Contributor Author

hjmallon commented Jan 6, 2021

See #2818

@hjmallon hjmallon deleted the pr.avif branch May 5, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants