Fix build break for older libheif #2814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cmstein confirms that this fixes his build break |
With some recent heic related packages, we lost the ability to build against some older libheif versions that we purport to support. We may eventually want to raise the minimum supported libheif, but in the mean time, this restores the prior build abilities.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Jan 5, 2021
With some recent heic related packages, we lost the ability to build against some older libheif versions that we purport to support. We may eventually want to raise the minimum supported libheif, but in the mean time, this restores the prior build abilities.
|
Thanks @lgritz I did have a horrible thought that something like this would be needed. |
|
We finally got bitten by the fact that most of our CI configurations don't have libheif installed at all. We should fix that, and make sure that the "oldest everything", "current releases", and "bleeding edge" CI tests are all using appropriate versions of libheif. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With some recent heic related packages, we lost the ability to build
against some older libheif versions that we purport to support. We may
eventually want to raise the minimum supported libheif, but in the
mean time, this restores the prior build abilities.