Filesystem::generic_filepath. #2819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to C++17 std::filesystem::path::generic_string(), but for a filepath sent as string_view. While I was there, I noticed that a few Filesystem functions that I declared as `noexcept` actually call things that can throw, so I put a few try/catch in stratgic spots. Nobody had reported a problem with this, and maybe it would be fine, but it's the right thing to do.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Jan 13, 2021
Similar to C++17 std::filesystem::path::generic_string(), but for a filepath sent as string_view. While I was there, I noticed that a few Filesystem functions that I declared as `noexcept` actually call things that can throw, so I put a few try/catch in stratgic spots. Nobody had reported a problem with this, and maybe it would be fine, but it's the right thing to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to C++17 std::filesystem::path::generic_string(), but for a
filepath sent as string_view.
While I was there, I noticed that a few Filesystem functions that I
declared as
noexceptactually call things that can throw, so I put afew try/catch in stratgic spots. Nobody had reported a problem with
this, and maybe it would be fine, but it's the right thing to do.