imagebuf_test: reset the IB before we remove the file it's reading #2834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a weird thing we're doing in this very artificial test, removing a file when the IB reading it is still alive. That's safe on Unix, where a file with an open file handle still be safe to read even if it's removed. But it's not kosher on Windows. Fix by simply making sure that in this test, we aren't doing the unadvised thing of having the IB still active on the file we're deleting. This should fix the unit_imagebuf test that is failing our Windows CI.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Jan 18, 2021
…cademySoftwareFoundation#2834) This is a weird thing we're doing in this very artificial test, removing a file when the IB reading it is still alive. That's safe on Unix, where a file with an open file handle still be safe to read even if it's removed. But it's not kosher on Windows. Fix by simply making sure that in this test, we aren't doing the unadvised thing of having the IB still active on the file we're deleting. This should fix the unit_imagebuf test that is failing our Windows CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a weird thing we're doing in this very artificial test,
removing a file when the IB reading it is still alive. That's safe on
Unix, where a file with an open file handle still be safe to read even
if it's removed. But it's not kosher on Windows. Fix by simply making
sure that in this test, we aren't doing the unadvised thing of having
the IB still active on the file we're deleting. This should fix the
unit_imagebuf test that is failing our Windows CI.