Don't use the version of libheif that's known to be broken on Mac #2847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it correct that libheif is still disabled in the CI? Or did I read that incorrect? |
|
It's enabled for Mac, disabled for Linux and Windows. I'll try turning on for Linux again and see what happens. |
|
Seems to work, so I will re-enable for several of the Linux CI tests. |
|
Great, thanks! Any chance it could also be turned on for Windows and macOS? libheif v1.11.0 should have some fixes for macOS. |
|
It has always been enabled for MacOS. Enabling on Windows would require building it from scratch, or having the Windows CI tests download a pre-built version, if that's easily available. It would be great to have a volunteer to do that CI work, I'm really strapped for time at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing failed CI tests and probably confused users.
libheif 1.10 is very broken on MacOS. The author says that 1.11 will come soon.