Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static building #2854

Merged
merged 3 commits into from Feb 3, 2021
Merged

Static building #2854

merged 3 commits into from Feb 3, 2021

Conversation

Shootfast
Copy link
Contributor

Description

Numerous small fixes for issues discovered when statically linking on Windows.

Tests

Checklist:

  • I have read the contribution guidelines.
  • If this is more extensive than a small change to existing code, I
    have previously submitted a Contributor License Agreement
    (individual, and if there is any way my
    employers might think my programming belongs to them, then also
    corporate).
  • I have updated the documentation, if applicable.
  • I have ensured that the change is tested somewhere in the testsuite
    (adding new test cases if necessary).
  • My code follows the prevailing code style of this project.

lgritz
lgritz approved these changes Feb 3, 2021
View reviewed changes
Copy link
Collaborator

@lgritz lgritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fixes.

Do you think we should aim to add a CI test to verify LINKSTATIC=1?

@lgritz lgritz merged commit 5c37eb1 into AcademySoftwareFoundation:master Feb 3, 2021
@Shootfast
Copy link
Contributor Author

A CI test for the static builds would be amazing, but I think it will be quite hard to set up.

On Windows (where I'm currently building a static OIIO) there is a lot of CMake mangling I am doing to point/trick all of the find_package scripts into working. Not to mention ensuring all the dependencies are built with the correct Debug/Release modes.

lgritz pushed a commit to lgritz/OpenImageIO that referenced this pull request Feb 4, 2021
@Shootfast @lgritz
Static building (AcademySoftwareFoundation#2854)
8b4ecb5 
* cmake: Make LibRaw Jasper and LCMS2 detection optional, add LIBRAW_NODLL

* cmake: Fix OpenColorIO defines on Windows to use correct cmake mechanism

* cmake: Add missing LibRaw defines (needed when linking statically)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgritz lgritz lgritz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Shootfast @lgritz