Targa read fix for tga files with 0-sized thumbnails #2903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of our prior tga tests had valid thumbnails. The code skipped the thumbnail if the "offset to the thumbnail" was 0. But if the offset was nonzero but the thumbnail record at that spot had a 0x0 size, we just ran merrily along, and on Windows in debug mode even it an assert. This patch makes it understand that a 0x0 thumbnail size means no thumbnail. I added an image from Doug Rogers, the reporter of the problem, to the oiio-images repo in the targa directory, and updated the OIIO testsuite to also check that image. (So testsuite will fail for people who don't update their oiio-images repo.)
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Mar 21, 2021
…Foundation#2903) All of our prior tga tests had valid thumbnails. The code skipped the thumbnail if the "offset to the thumbnail" was 0. But if the offset was nonzero but the thumbnail record at that spot had a 0x0 size, we just ran merrily along, and on Windows in debug mode even it an assert. This patch makes it understand that a 0x0 thumbnail size means no thumbnail. I added an image from Doug Rogers, the reporter of the problem, to the oiio-images repo in the targa directory, and updated the OIIO testsuite to also check that image. (So testsuite will fail for people who don't update their oiio-images repo.) Also changed some stray refs to &vector[0] to vector.data(). Fixes AcademySoftwareFoundation#2900
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of our prior tga tests had valid thumbnails. The code skipped the
thumbnail if the "offset to the thumbnail" was 0. But if the offset was
nonzero but the thumbnail record at that spot had a 0x0 size, we just
ran merrily along, and on Windows in debug mode even it an assert.
This patch makes it understand that a 0x0 thumbnail size means no
thumbnail.
I added an image from Doug Rogers, the reporter of the problem, to the
oiio-images repo in the targa directory, and updated the OIIO testsuite
to also check that image. (So testsuite will fail for people who don't
update their oiio-images repo.)
Also changed some stray refs to &vector[0] to vector.data().
Fixes #2900