Avoid OCIO 2 exception by setting strides correctly #2911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the case of applying a color transformation to just one color, we were sloppy and set the strides to 0 (just one color means we are not iterating from point to point using the strides). OpenColorIO 1.x didn't care, but OpenColorIO 2.0 throws an exception if the strides don't look valid. Thanks to Thomas Metais for the fix suggestion.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Mar 26, 2021
…oundation#2911) For the case of applying a color transformation to just one color, we were sloppy and set the strides to 0 (just one color means we are not iterating from point to point using the strides). OpenColorIO 1.x didn't care, but OpenColorIO 2.0 throws an exception if the strides don't look valid. Thanks to Thomas Metais for the fix suggestion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the case of applying a color transformation to just one color, we
were sloppy and set the strides to 0 (just one color means we are not
iterating from point to point using the strides).
OpenColorIO 1.x didn't care, but OpenColorIO 2.0 throws an exception if
the strides don't look valid.
Thanks to Thomas Metais for the fix suggestion.