Fix ImageBuf::read bug for images of mixed per-channel data types #3088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When it comes time to read_image() into the ImageBuf's internal memory, we should have said to convert to `m_spec.format`, which describes the buffer we allocated. Instead, we asked for `convert`, which is the user request, which at that time can still be UNKNOWN, which indicates to preserve the file's data format, which in fact does not necessarily match the internal buffer. This becomes especially troublesome for images with mixed per-channel data types, which will obviously never match the internal buffer since ImageBuf only internally stores one data format for all channels.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Sep 15, 2021
…ademySoftwareFoundation#3088) When it comes time to read_image() into the ImageBuf's internal memory, we should have said to convert to `m_spec.format`, which describes the buffer we allocated. Instead, we asked for `convert`, which is the user request, which at that time can still be UNKNOWN, which indicates to preserve the file's data format, which in fact does not necessarily match the internal buffer. This becomes especially troublesome for images with mixed per-channel data types, which will obviously never match the internal buffer since ImageBuf only internally stores one data format for all channels.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Feb 1, 2022
…ademySoftwareFoundation#3088) When it comes time to read_image() into the ImageBuf's internal memory, we should have said to convert to `m_spec.format`, which describes the buffer we allocated. Instead, we asked for `convert`, which is the user request, which at that time can still be UNKNOWN, which indicates to preserve the file's data format, which in fact does not necessarily match the internal buffer. This becomes especially troublesome for images with mixed per-channel data types, which will obviously never match the internal buffer since ImageBuf only internally stores one data format for all channels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When it comes time to read_image() into the ImageBuf's internal
memory, we should have said to convert to
m_spec.format, whichdescribes the buffer we allocated. Instead, we asked for
convert,which is the user request, which at that time can still be UNKNOWN,
which indicates to preserve the file's data format, which in fact does
not necessarily match the internal buffer.
This becomes especially troublesome for images with mixed per-channel
data types, which will obviously never match the internal buffer since
ImageBuf only internally stores one data format for all channels.
Fixes #2691