Testing: test both openexr old and core versions #3604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On any one platform, our testsuite was only testing the old C++ and the new C core exr implementations. Rig it to run the openexr-oriented tests twice -- once in each state (when using OpenEXR new enough to support the core library). Doing this cleanly required adding SUFFIX and ENVIRONMENT optional parameters to the oiio_add_tests utility macro. Once that was added, the texture batch testing could be implemented that way as well, removing a bunch of hackier special purpose code.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Oct 17, 2022
…dation#3604) On any one platform, our testsuite was only testing the old C++ and the new C core exr implementations. Rig it to run the openexr-oriented tests twice -- once in each state (when using OpenEXR new enough to support the core library). Doing this cleanly required adding SUFFIX and ENVIRONMENT optional parameters to the oiio_add_tests utility macro. Once that was added, the texture batch testing could be implemented that way as well, removing a bunch of hackier special purpose code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On any one platform, our testsuite was only testing the old C++ or the new C core exr implementations.
Rig it to run the openexr-oriented tests twice -- once in each state (when using OpenEXR new enough to support the core library).
Doing this cleanly required adding SUFFIX and ENVIRONMENT optional parameters to the oiio_add_tests utility macro. Once that was added, the texture batch testing could be implemented that way as well, removing a bunch of hackier special purpose code.