DDS: fix crashes and add tests #3625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In the case of DDS cubemap files where a cube face was not present, we were filling m_buf with 0 bytes before allocating it. * Add check for invalid bits per pixel. * Add regression test for another bug that was perviously fixed in 2.4.3.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Oct 23, 2022
* In the case of DDS cubemap files where a cube face was not present, we were filling m_buf with 0 bytes before allocating it. * Add check for invalid bits per pixel. * Add regression test for another bug that was perviously fixed in 2.4.3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of DDS cubemap files where a cube face was not present, we were filling m_buf with 0's before allocating it.
Add check for invalid bits per pixel.
Add regression test for another bug that was previously fixed in 2.4.3.