Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BMP output safety #3673

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Commits on Nov 15, 2022

  1. BMP output safety

    In open(), check for non-zero image offsets, which is not supported by
    BMP, and issue an error if found. If the spec passed in has nonzero
    spec.y, other code in the write functions would fail because they
    assumed spec.y == 0 and could therefore access memory incorrectly.
    
    More generally, also put checks in the write functions that issue
    errors and take early outs if they find that they are called on a
    BMPOutput that is not currently open, for example if open() fails but
    the user doesn't check the return codes and proceeds to call the write
    functions anyway.
    
    This addresses 1653
    lgritz committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    1067469 View commit details
    Browse the repository at this point in the history