-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix building on OpenBSD #3808
Fix building on OpenBSD #3808
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
LGTM, though it seems to be failing the "clang-format" test, can you please fix the line wrap here? (Click on the failed test to see where it "breaks," which will include the diff that shows how to make it conform.)
372db9a
to
d24c5c4
Compare
Sure thing, done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks. Will merge as soon as the rest of the CI passes.
efe2fe0
Oops, I thought the "merge queue" would wait until all the checks passed. Oh well. I think it's safe, I don't think this can affect any non-OpenBSD builds, which of course aren't included in our CI. |
Please backport to 2.5 and 2.4. |
I backported to 2.4 (in the dev-2.4 branch) and it will be part of the next tagged release scheduled for 1 May. I'm not sure what you mean by "backport to 2.5." There is no official 2.5 release family yet; the current "master" branch is what will become 2.5 later this year. |
I saw something that looked like tags towards a 2.5 release and wasn't sure so included it just in case. |
Yeah, I occasionally add "developer preview" tags to mark places that seem stable in the master branch, for people who need things that are only in master. But there's no support or backporting for those, just the occasional tag dropped to mark "I've used it in production here, seems ok." |
No description provided.