Fix: Build error with MSVC #3832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssize_t is a posix type, msvc seemingly doesn't know about leading to a build error with MSVC 2019 usage elsewhere in this files used the `py::ssize_t` type, which seems to fix this
lgritz
approved these changes
May 8, 2023
lgritz
merged commit 0a39c2c
into
AcademySoftwareFoundation:master
19 of 20 checks passed
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
May 9, 2023
`ssize_t` is a posix type, msvc seemingly doesn't know about leading to a build error with MSVC 2019 usage elsewhere in this files used the `py::ssize_t` type, which seems to fix this
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
May 14, 2023
`ssize_t` is a posix type, msvc seemingly doesn't know about leading to a build error with MSVC 2019 usage elsewhere in this files used the `py::ssize_t` type, which seems to fix this
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
May 15, 2023
`ssize_t` is a posix type, msvc seemingly doesn't know about leading to a build error with MSVC 2019 usage elsewhere in this files used the `py::ssize_t` type, which seems to fix this
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
May 15, 2023
`ssize_t` is a posix type, msvc seemingly doesn't know about leading to a build error with MSVC 2019 usage elsewhere in this files used the `py::ssize_t` type, which seems to fix this
birsoyo
pushed a commit
to birsoyo/oiio
that referenced
this pull request
Jun 8, 2023
`ssize_t` is a posix type, msvc seemingly doesn't know about leading to a build error with MSVC 2019 usage elsewhere in this files used the `py::ssize_t` type, which seems to fix this
birsoyo
pushed a commit
to birsoyo/oiio
that referenced
this pull request
Jun 8, 2023
`ssize_t` is a posix type, msvc seemingly doesn't know about leading to a build error with MSVC 2019 usage elsewhere in this files used the `py::ssize_t` type, which seems to fix this
birsoyo
pushed a commit
to birsoyo/oiio
that referenced
this pull request
Jun 8, 2023
`ssize_t` is a posix type, msvc seemingly doesn't know about leading to a build error with MSVC 2019 usage elsewhere in this files used the `py::ssize_t` type, which seems to fix this
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ssize_tis a posix type, msvc seemingly doesn't know about leading to a build error with MSVC 2019usage elsewhere in this files used the
py::ssize_ttype, which seems to fix thisChecklist: