jpeg output: fix density calculation #3861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgritz
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
I think you are right. This part of the code is really confusing because we are trying to mimic a misunderstanding of several apps that appears to contradict the JFIF spec. But I think that you are just making the "neither one is set" conform to the twisted logic we had for ("only one of xres or yres is set").
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Jun 2, 2023
…undation#3861) In `jpegoutput.cpp` when computing the density fields the relationship between `XRes`, `YRes` and `aspect` is `aspect = XRes / YRes`. However this relationship was not respected in one specific case, when `aspect >= 1.0` and `XRes` and `YRes` are not set. This PR solves this problem by enforcing the correct relationship. Related to: AcademySoftwareFoundation#2822
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
jpegoutput.cppwhen computing the density fields the relationship betweenXRes,YResandaspectisaspect = XRes / YRes.However this relationship was not respected in one specific case, when
aspect >= 1.0andXResandYResare not set.This PR solves this problem by enforcing the correct relationship.
Related to: #2822