ci: Fix broken heif dependency and test #3894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The strukturag repo for libheif recently upgrade the version it was serving from 1.14 to 1.16, and that caused our tests to fail because (a) some of the coded support has been moved to plugins that are loaded at runtime and those are distributed in separate pacakges we need to install; (b) you must call heif_init() or it won't know about the optional plugins. Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Jul 1, 2023
The strukturag repo for libheif recently upgraded the version it was serving from 1.14 to 1.16, and that caused our tests to fail because (a) some of the codec support has been moved to plugins that are loaded at runtime and those are now distributed in packages we need to install separately; (b) you must call heif_init() or it won't know about the optional plugins. Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
added a commit
that referenced
this pull request
Sep 1, 2023
Typo introduced in #3894 broke our ability to build against libheif < 1.13. A conditional compilation that should have kicked in for >=1.16 was mistakenly written as 1.6. Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Sep 1, 2023
Typo introduced in AcademySoftwareFoundation#3894 broke our ability to build against libheif < 1.13. A conditional compilation that should have kicked in for >=1.16 was mistakenly written as 1.6. Signed-off-by: Larry Gritz <lg@larrygritz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The strukturag repo for libheif recently upgraded the version it was serving from 1.14 to 1.16, and that caused our tests to fail because (a) some of the codec support has been moved to plugins that are loaded at runtime and those are now distributed in packages we need to install separately; (b) you must call heif_init() or it won't know about the optional plugins.