CMYK PSD files should copy alpha #3918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need the DCO sign-off on these commits as well. |
jasonbaumeister
force-pushed
the
cmyk_psd_fix
branch
2 times, most recently
from
91b40d2
to
cfac1c0
Compare
Should all be squashed and signed now. |
jasonbaumeister
force-pushed
the
cmyk_psd_fix
branch
from
cfac1c0
to
d39fcb6
Compare
adding a test Signed-off-by: Jason Baumeister <jason@jasonbaumeister.com>
jasonbaumeister
force-pushed
the
cmyk_psd_fix
branch
from
d39fcb6
to
932623b
Compare
lgritz
merged commit 88d354e
into
AcademySoftwareFoundation:master
22 of 23 checks passed
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Jul 29, 2023
…#3918) During the CMYK to RGB conversion in PSDInput, the alpha channel was never copied to the RGBA output. Converting a PSD to JPEG worked because it ignored all the 0 alpha values, but converting to WebP would result in a fully transparent image. I added a cmyk-with-alpha.psd test to the psd-colormodes test to check this Signed-off-by: Jason Baumeister <jason@jasonbaumeister.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During the CMYK to RGB conversion in PSDInput, the alpha channel was never copied to the RGBA output. Converting a PSD to JPEG worked because it ignored all the 0 alpha values, but converting to WebP would result in a fully transparent image.
Tests
I added a cmyk-with-alpha.psd test to the psd-colormodes test to check this
Checklist:
have previously submitted a Contributor License Agreement
(individual, and if there is any way my
employers might think my programming belongs to them, then also
corporate).
(adding new test cases if necessary).