Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print build-time warnings for LGPL gotchas #3958

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Print build-time warnings for LGPL gotchas #3958

merged 1 commit into from
Sep 20, 2023

Conversation

grdanny
Copy link
Contributor

@grdanny grdanny commented Aug 24, 2023

Trying out my first Mackerel from:

#3916

@grdanny grdanny closed this Aug 24, 2023
@grdanny grdanny force-pushed the 3916_build_time_warning_for_lgpl branch from abb9737 to cfaccc1 Compare August 24, 2023 01:27
@grdanny grdanny reopened this Aug 24, 2023
@grdanny grdanny force-pushed the 3916_build_time_warning_for_lgpl branch from d6197ea to 9c23ce9 Compare August 24, 2023 06:29
lgritz
lgritz requested changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@lgritz lgritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're on the right track to fully solve this issue. I recommended a few minor changes.

src/ffmpeg.imageio/CMakeLists.txt Outdated Show resolved Hide resolved
src/heif.imageio/CMakeLists.txt Outdated Show resolved Hide resolved
src/heif.imageio/CMakeLists.txt Outdated Show resolved Hide resolved
@grdanny grdanny force-pushed the 3916_build_time_warning_for_lgpl branch from a4019aa to a37119b Compare September 18, 2023 02:32
@grdanny
Copy link
Contributor Author

grdanny commented Sep 18, 2023

This should be ready for review.
The only additional thought I had was maybe to turn this into a macro and share across the two cases (and maybe then it's useful in some other similar future case?)
But not sure if that is more helpful or confusing, right now it should be pretty clear why we added this.

@grdanny
printing out message with regards to LGPL licensing issues when linki…
800b458 
…ng against static versions of ffmpeg and libheif

Signed-off-by: grdanny <danny.gr@gmail.com>
@grdanny grdanny force-pushed the 3916_build_time_warning_for_lgpl branch from a37119b to 800b458 Compare September 18, 2023 03:53
@lgritz
Copy link
Collaborator

lgritz commented Sep 20, 2023

I think it's fine as it is, Danny. These are the only two instances of this that we know about. If another pops up, we can think about whether to refactor into some common infrastructure.

@lgritz
Copy link
Collaborator

lgritz commented Sep 20, 2023

Fixes #3916

@lgritz lgritz linked an issue Sep 20, 2023 that may be closed by this pull request
[FEATURE REQUEST] Print build-time warnings for LGPL gotchas #3916
Closed
@lgritz lgritz merged commit b3ac0a2 into AcademySoftwareFoundation:master Sep 20, 2023
24 checks passed
lgritz pushed a commit to lgritz/OpenImageIO that referenced this pull request Sep 20, 2023
@grdanny @lgritz
Print build-time warnings for LGPL gotchas (AcademySoftwareFoundation…
af1f2df 
…#3958)

Print helpful reminder to check licenses when using libheif or
ffmpeg statically linked.

Fixes AcademySoftwareFoundation#3916

Signed-off-by: grdanny <danny.gr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgritz lgritz lgritz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Print build-time warnings for LGPL gotchas
2 participants
@grdanny @lgritz