Fix #3951: Invalid read from an empty vector during RLA load #3960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… during RLA load Signed-off-by: Jesse Yurkovich <jesse.y@gmail.com>
Signed-off-by: Jesse Yurkovich <jesse.y@gmail.com>
|
Fixes #3951 |
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Aug 25, 2023
…oftwareFoundation#3960) The incoming length of the RLE data could be 0. In this case we would attempt to take the address of the 1st element of an empty vector. Added a new 1004-byte file to the local test suite. Fixes AcademySoftwareFoundation#3951 --------- Signed-off-by: Jesse Yurkovich <jesse.y@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The incoming length of the RLE data could be 0. In this case we would attempt to take the address of the 1st element of an empty vector.
Tests
Added a new 1004-byte file to the local test suite.
Checklist:
(adding new test cases if necessary).
corresponding Python bindings (and if altering ImageBufAlgo functions, also
exposed the new functionality as oiiotool options).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.