Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check for Boost_NO_BOOST_CMAKE, ignore if already set #3961

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

mikaelsundell
Copy link
Contributor

Enable set of Boost_NO_BOOST_CMAKE through make using MY_CMAKE_FLAGS=-DBoost_NO_BOOST_CMAKE:BOOL=OFF.

Copy link
Collaborator

@lgritz lgritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could you please add the DCO sign-off to the commit and re-(force-)push? Thanks.

Signed-off-by: Mikael Sundell <mikael.sundell@gmail.com>
Copy link
Collaborator

@lgritz lgritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing the DCO.

@lgritz lgritz merged commit 38aed29 into AcademySoftwareFoundation:master Aug 24, 2023
23 checks passed
lgritz pushed a commit to lgritz/OpenImageIO that referenced this pull request Aug 25, 2023
…cademySoftwareFoundation#3961)

Enable set of Boost_NO_BOOST_CMAKE through make using
MY_CMAKE_FLAGS=-DBoost_NO_BOOST_CMAKE:BOOL=OFF.

Signed-off-by: Mikael Sundell <mikael.sundell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants