fix(ustring): fix Cuda warnings #3978
Conversation
To my eyes, these two constructors look like they should be treated as
doing exactly the same thing:
MyType()
: mymember(...)
{ }
and
MyType()
{
mymember = ...;
}
But nvcc in Cuda mode says no, if the constructor is constexpr,
the former is okey dokey, but latter gives a warning. Fine, Cuda,
whatver you say.
Signed-off-by: Larry Gritz <lg@larrygritz.com>
There was a problem hiding this comment.
I think this was an issue in C++ as well until c++20, as we can see in these c++ examples: https://gcc.godbolt.org/z/63n7n36os with clang and gcc.
I don't know if this is a good idea, but you could create a macro (and then undef it later) that does the Strutil::strhash(str) / ustring(str).hash() and then you won't need all these ifdefs and comments in the various ustringhash constructors. This might not be worth it for just three places, so I'm approving it as is.
|
Yes. The warning specifically says "this is not allowed until C++20". Still surprising to me that even before C++20, any compiler or the language would treat unconditional assignment of the sole member variable inside the braces as being any different than the |
To my eyes, these two constructors look like they should be treated as
doing exactly the same thing:
MyType()
: mymember(...)
{ }
and
MyType()
{
mymember = ...;
}
But nvcc in Cuda mode says no, if the constructor is constexpr, the
former is okey dokey, but latter gives a warning. Fine, Cuda, whatver
you say.
Signed-off-by: Larry Gritz <lg@larrygritz.com>
To my eyes, these two constructors look like they should be treated as
doing exactly the same thing:
MyType()
: mymember(...)
{ }
and
MyType()
{
mymember = ...;
}
But nvcc in Cuda mode says no, if the constructor is constexpr, the
former is okey dokey, but latter gives a warning. Fine, Cuda, whatver
you say.
Signed-off-by: Larry Gritz <lg@larrygritz.com>
To my eyes, these two constructors look like they should be treated as doing exactly the same thing:
and
But nvcc in Cuda mode says no, if the constructor is constexpr, the former is okey dokey, but latter gives a warning. Fine, Cuda, whatver you say.