Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: Set up placeholders for docs-examples-are-tests #3994

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

lgritz
Copy link
Collaborator

@lgritz lgritz commented Sep 21, 2023

I had previously prototyped an instance of this for the ImageOutput chapter.

This patch makes empty placeholders for all of the other API chapters. They don't contain any actual tests or generate any output now, but they do build and run, so people can drop new examples into them without having to worry about how to set up new files for each chapter.

I had previously prototyped an instance of this for the ImageOutput
chapter.

This patch makes empty placeholders for all of the other API chapters.
They don't contain any actual tests or generate any output now, but
they do build and run, so people can drop new examples into them
without having to worry about how to set up new files for each
chapter.

Signed-off-by: Larry Gritz <lg@larrygritz.com>
# "example1" to a helpful short name that identifies the example.


# BEGIN-imageinput-example1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be BEGIN-imagebuf-example1 (along with the END below)

Copy link
Contributor

@jessey-git jessey-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 1 minor comment but the rest is fine!

Signed-off-by: Larry Gritz <lg@larrygritz.com>
@lgritz
Copy link
Collaborator Author

lgritz commented Sep 21, 2023

Thanks. I tried to fix all my copy pasta, but it doesn't surprise me that I missed one.

@lgritz lgritz merged commit 69c412e into AcademySoftwareFoundation:master Sep 21, 2023
24 checks passed
@lgritz lgritz deleted the lg-docsexamples branch September 21, 2023 23:25
lgritz added a commit to lgritz/OpenImageIO that referenced this pull request Sep 25, 2023
…wareFoundation#3994)

I had previously prototyped an instance of this for the ImageOutput
chapter.

This patch makes empty placeholders for all of the other API chapters.
They don't contain any actual tests or generate any output now, but they
do build and run, so people can drop new examples into them without
having to worry about how to set up new files for each chapter.

---------

Signed-off-by: Larry Gritz <lg@larrygritz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants