-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2058] Implement Directory Argument Loading for iv #4010
[2058] Implement Directory Argument Loading for iv #4010
Conversation
I've added a processing area for the extensions since they're formatted like Also, just saw the message on slack to sign my commits, so this next commit is just a signing commit |
3629d9c
to
e8395ec
Compare
@CheeksTheGeek ALL the commits need to be signed. (Silly, yes, but that's what the bot is looking for.) The easiest way to do this is
This will bring up an editor window with the list of commits. Change "pick" to "r" on every line and save & exit. It will then bring up an editor on each commit in sequence, allowing you to edit the commit messages individually. For each one, just add this line:
and save & exit. When this is all done, |
…d to the viewer Signed-off-by: Chaitanya Sharma <39400946+CheeksTheGeek@users.noreply.github.com>
Signed-off-by: Chaitanya Sharma <39400946+CheeksTheGeek@users.noreply.github.com>
Signed-off-by: Chaitanya Sharma <39400946+CheeksTheGeek@users.noreply.github.com>
Signed-off-by: Chaitanya Sharma <39400946+CheeksTheGeek@users.noreply.github.com>
Signed-off-by: Chaitanya Sharma <39400946+CheeksTheGeek@users.noreply.github.com>
e8395ec
to
23c5325
Compare
Done! |
I build and tested this on my end -- works as advertised, very nice! |
Signed-off-by: Chaitanya Sharma <39400946+CheeksTheGeek@users.noreply.github.com>
Done! |
Works very well! There is one small behavior that is surprising. I guess when you enumerate directory entries, it comes out in any random order (I suppose in the order the files within the directory appears to the OS), and that's a little surprising because if you'd said I wonder if you would mind putting in an extra step so that the files within each directory are sorted lexicographically? (But only within each directory, not across all files and directories, if you know what I mean.) |
Signed-off-by: Chaitanya Sharma <39400946+CheeksTheGeek@users.noreply.github.com>
Done! |
Thank you, the sorting definitely is better behavior. The only other request I had is about those blank line, but otherwise I think this is basically complete! |
Signed-off-by: Chaitanya Sharma <39400946+CheeksTheGeek@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
8d04dae
into
AcademySoftwareFoundation:master
…eFoundation#4010) Solves the issue "Load a directory: iv dirname ought to be the same as specifying all the image files in that directory" from the Great Big iv Wish List AcademySoftwareFoundation#2058 This PR addresses the request from the Master list of iv feature requests to allow loading a directory as an argument, which in turn loads all images within the specified directory. The code modifications include checks to validate the file or directory existence, and if a directory is provided, iterates through its files to load all valid images into iv. This enhancement simplifies the process of viewing multiple images collectively located in a single directory. --------- Signed-off-by: Chaitanya Sharma <39400946+CheeksTheGeek@users.noreply.github.com>
Solves the issue "Load a directory: iv dirname ought to be the same as specifying all the image files in that directory" from the Great Big iv Wish List #2058
Description
This PR addresses the request from the Master list of iv feature requests to allow loading a directory as an argument, which in turn loads all images within the specified directory. The code modifications include checks to validate the file or directory existence, and if a directory is provided, iterates through its files to load all valid images into iv. This enhancement simplifies the process of viewing multiple images collectively located in a single directory.
Tests
N/A
Checklist:
(adding new test cases if necessary).
corresponding Python bindings (and if altering ImageBufAlgo functions, also
exposed the new functionality as oiiotool options).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.