fix: to_OpenCV fails for ImageCache-backed images #4013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using parallel_convert_image but not realizing that asking for the IB::localpixels() would give us nullptr for an IC-backed image. Instead, "wrap" the cv::Mat with an IB and then use IBA::copy(). This handles both in-memory and IC-backed ImageBuf's, and also has many other advantages (such as format conversion) we may wish to take advantage of in the future. Signed-off-by: Larry Gritz <lg@larrygritz.com>
|
On #3800, the original reporter of the issue confirms that this patch fixes the problem. Merging. |
lgritz
merged commit 1484315
into
AcademySoftwareFoundation:master
23 of 25 checks passed
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Oct 14, 2023
…reFoundation#4013) We were using parallel_convert_image but not realizing that asking for the IB::localpixels() would give us nullptr for an IC-backed image. Instead, "wrap" the cv::Mat with an IB and then use IBA::copy(). This handles both in-memory and IC-backed ImageBuf's, and also has many other advantages (such as format conversion) we may wish to take advantage of in the future. Fixes AcademySoftwareFoundation#3800 Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
added a commit
that referenced
this pull request
Oct 20, 2023
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Oct 20, 2023
…reFoundation#4013) We were using parallel_convert_image but not realizing that asking for the IB::localpixels() would give us nullptr for an IC-backed image. Instead, "wrap" the cv::Mat with an IB and then use IBA::copy(). This handles both in-memory and IC-backed ImageBuf's, and also has many other advantages (such as format conversion) we may wish to take advantage of in the future. Fixes AcademySoftwareFoundation#3800 Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Oct 20, 2023
Testing to make sure we can convert an IC-backed IB to a cv::Mat. Related to issue AcademySoftwareFoundation#3800 and PR AcademySoftwareFoundation#4013 Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Oct 20, 2023
Testing to make sure we can convert an IC-backed IB to a cv::Mat. Related to issue AcademySoftwareFoundation#3800 and PR AcademySoftwareFoundation#4013 Signed-off-by: Larry Gritz <lg@larrygritz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using parallel_convert_image but not realizing that asking for the IB::localpixels() would give us nullptr for an IC-backed image.
Instead, "wrap" the cv::Mat with an IB and then use IBA::copy(). This handles both in-memory and IC-backed ImageBuf's, and also has many other advantages (such as format conversion) we may wish to take advantage of in the future.
Fixes #3800