feat: split off the current image in iv into a separate window (#2058) #4017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The new window gets initialised with the default settings. I'm not sure how much of the current window's viewer state we want to retain. |
|
Nice! Instead of "split off", I would suggest calling the menu item "Move to new window", that seems to be what the equivalent operation is called in some other apps I just randomly sampled (Firefox, Chrome, Obsidian). |
lgritz
requested changes
Oct 12, 2023
antond-weta
force-pushed
the
iv_split_off
branch
from
204f54f
to
7be78fd
Compare
…mySoftwareFoundation#2058) Signed-off-by: Anton Dukhovnikov <antond@wetafx.co.nz>
antond-weta
force-pushed
the
iv_split_off
branch
from
7be78fd
to
90842d1
Compare
Thanks Larry, I have renamed the command. |
|
Aha, your CLA is working now! @antond-weta, there appear to be a couple very minor clang-format fixes needed. As soon as that's ready, we're definitely ready to merge this. |
…fix formatting Signed-off-by: Anton Dukhovnikov <antond@wetafx.co.nz>
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Oct 20, 2023
…cademySoftwareFoundation#4017) This change adds a menu item "Move to new window" under the menu "File" which creates a new window and initialises it with the currently displayed image. I have tested the UI changes on Mac and linux, I don't have a Windows machine currently. No other functionality should be affected by this change. This was one item from issue AcademySoftwareFoundation#2058 --------- Signed-off-by: Anton Dukhovnikov <antond@wetafx.co.nz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds a menu item "Split off" under the menu "File" which creates a new window and initialises it with the currently displayed image.
Tests
I have tested the UI changes on Mac and linux, I don't have a Windows machine currently.
No other functionality should be affected by this change.
Checklist:
(adding new test cases if necessary).
corresponding Python bindings (and if altering ImageBufAlgo functions, also
exposed the new functionality as oiiotool options).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.