LibRaw wavelet denoise options #4028
Conversation
``raw:threshold``
- float
- Libraw parameter for noise reduction through wavelet denoising..
The best threshold should be somewhere between 100 and 1000.
- ``raw:fbdd_noiserd``
- int
- Controls FBDD noise reduction before demosaic.
0 - do not use FBDD noise reduction, 1 - light FBDD reduction,
2 (and more) - full FBDD reduction
Signed-off-by: ssh4net <libalias@gmail.com>
|
@lgritz nothing special just two options: but fbdd_noiserd I did not get how it works in libraw so just added it as it is also about denoising (1 or 2 should enable different modes of this pre-demosaic denoiser). My main concern, that compared to direct libraw demosaic that not affect processing time a lot. OpenImageIO has 2-3 times slowdown on wavelet demosaic, |
|
Check the CI run to see that clang-format found a couple of very minor things, but other than that, it looks good to me. |
Signed-off-by: ssh4net <libalias@gmail.com>
|
Fixed. Do you have any ideas why enabling this pre-demosaic denoising can have such a significant impact on plugin speed when libraw directly has only 5-10% slowdown? |
src/doc/builtinplugins.rst
Outdated
| - Controls FBDD noise reduction before demosaic. | ||
| 0 - do not use FBDD noise reduction, 1 - light FBDD reduction, | ||
| 2 (and more) - full FBDD reduction | ||
| (Default: 0.0) |
There was a problem hiding this comment.
I'm sorry, last thing, I promise! Since this one is an integer parameter, let's document the default as 0 instead of 0.0.
Signed-off-by: Larry Gritz <lg@larrygritz.com>
- ``raw:threshold``
- float
- Libraw parameter for noise reduction through wavelet denoising..
The best threshold should be somewhere between 100 and 1000.
- ``raw:fbdd_noiserd``
- int
- Controls FBDD noise reduction before demosaic. 0 - do not use FBDD
noise reduction, 1 - light FBDD reduction, 2 (and more) - full FBDD reduction
---------
Signed-off-by: ssh4net <libalias@gmail.com>
raw:threshold- float
- Libraw parameter for noise reduction through wavelet denoising..
The best threshold should be somewhere between 100 and 1000.
raw:fbdd_noiserd- int - Controls FBDD noise reduction before demosaic. 0 - do not use FBDD noise reduction, 1 - light FBDD reduction, 2 (and more) - full FBDD reductionDescription
Tests
Checklist:
(adding new test cases if necessary).
corresponding Python bindings (and if altering ImageBufAlgo functions, also
exposed the new functionality as oiiotool options).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.