build: Adjust OpenVDB version requirements vs C++17 #4030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revision of PR 4023 I have since realized that although OpenVDB raised their own build requirements to C++17 starting with 10.0, it wasn't until 10.1 that C++17-isms crept into their header files and force downstream projects to need C++17 to consume OpenVDB's headers. Signed-off-by: Larry Gritz <lg@larrygritz.com>
ThiagoIze
approved these changes
Oct 17, 2023
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Oct 19, 2023
…oundation#4030) Revision of PR AcademySoftwareFoundation#4023 I have since determined that although OpenVDB raised their own build requirements to C++17 starting with 10.0, it wasn't until 10.1 that C++17-isms crept into their header files and force downstream projects to need C++17 to consume OpenVDB's headers. So we can go back to allowing use of OpenVDB 10.0 even when we are building with C++14. Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Oct 20, 2023
…oundation#4030) Revision of PR AcademySoftwareFoundation#4023 I have since determined that although OpenVDB raised their own build requirements to C++17 starting with 10.0, it wasn't until 10.1 that C++17-isms crept into their header files and force downstream projects to need C++17 to consume OpenVDB's headers. So we can go back to allowing use of OpenVDB 10.0 even when we are building with C++14. Signed-off-by: Larry Gritz <lg@larrygritz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revision of PR #4023
I have since determined that although OpenVDB raised their own build requirements to C++17 starting with 10.0, it wasn't until 10.1 that C++17-isms crept into their header files and force downstream projects to need C++17 to consume OpenVDB's headers. So we can go back to allowing use of OpenVDB 10.0 even when we are building with C++14.