test: improve color management test in imagebufalgo_test #4063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a few more assertion checks and error messages in imagebufalgo_test. I observe that if somebody runs the testsuite with $OCIO set to a config that doesn't contain the required color space names for this test, it will fail. As a backstop, use the default built-in config if the initial request fails. That will always give a working processor between these spaces if OCIO >= 2.2 is being used. Also one more tiny SPI-specific enhancement to hacky identification of nonconforming color space names in our old configs. Signed-off-by: Larry Gritz <lg@larrygritz.com>
doug-walker
reviewed
Nov 27, 2023
| // try again using the built-in config (OCIO 2.2+) and hope for the best. | ||
| if (!processor) | ||
| processor = ColorConfig("ocio://default") | ||
| .createColorProcessor("lin_srgb", "srgb"); |
There was a problem hiding this comment.
Did you mean "srgb_texture" rather than "srgb" here? (The latter is not in the default config.)
There was a problem hiding this comment.
It's not in the default config, but I make an alias for it.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Dec 10, 2023
…wareFoundation#4063) Add a few more assertion checks and error messages in imagebufalgo_test. I observe that if somebody runs the testsuite with `$OCIO` set to a config that doesn't contain the required color space names for this test, it will fail. As a backstop, use the default built-in config if the initial request fails. That will always give a working processor between these spaces if OCIO >= 2.2 is being used. Also one more tiny SPI-specific enhancement to hacky identification of nonconforming color space names in our old configs. Signed-off-by: Larry Gritz <lg@larrygritz.com>
1div0
pushed a commit
to 1div0/OpenImageIO
that referenced
this pull request
Feb 24, 2024
…wareFoundation#4063) Add a few more assertion checks and error messages in imagebufalgo_test. I observe that if somebody runs the testsuite with `$OCIO` set to a config that doesn't contain the required color space names for this test, it will fail. As a backstop, use the default built-in config if the initial request fails. That will always give a working processor between these spaces if OCIO >= 2.2 is being used. Also one more tiny SPI-specific enhancement to hacky identification of nonconforming color space names in our old configs. Signed-off-by: Larry Gritz <lg@larrygritz.com> Signed-off-by: Peter Kovář <peter.kovar@reflexion.tv>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a few more assertion checks and error messages in imagebufalgo_test.
I observe that if somebody runs the testsuite with
$OCIOset to a config that doesn't contain the required color space names for this test, it will fail. As a backstop, use the default built-in config if the initial request fails. That will always give a working processor between these spaces if OCIO >= 2.2 is being used.Also one more tiny SPI-specific enhancement to hacky identification of nonconforming color space names in our old configs.