-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only check REST arguments if the file does not exist #4085
Merged
lgritz
merged 1 commit into
AcademySoftwareFoundation:master
from
AdamMainsTL:fix/imageinput-rest-check
Dec 22, 2023
Merged
Only check REST arguments if the file does not exist #4085
lgritz
merged 1 commit into
AcademySoftwareFoundation:master
from
AdamMainsTL:fix/imageinput-rest-check
Dec 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The solution looks right to me! Can you please amend to fix the DCO signoff? The easiest way would be
|
Signed-off-by: AdamMainsTL <adam.mains@topazlabs.com>
AdamMainsTL
force-pushed
the
fix/imageinput-rest-check
branch
from
December 21, 2023 22:46
195fe7d
to
f206e09
Compare
Should be done! |
lgritz
approved these changes
Dec 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
And I will backport to the release branch for the Jan 1 patch release.
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Dec 22, 2023
…twareFoundation#4085) Fix for AcademySoftwareFoundation#4084. Will now check if the given filename exists before checking for REST parameters. Before: ``` bin % ./oiiotool \?.png -o \?-output.png oiiotool ERROR: read : "?.png": ImageInput::create() called with malformed filename Full command line was: > oiiotool ?.png -o ?-output.png ``` After: ``` bin % ./oiiotool \?.png -o \?-output.png ``` No output, `?-output.png` created. Signed-off-by: AdamMainsTL <adam.mains@topazlabs.com>
1div0
pushed a commit
to 1div0/OpenImageIO
that referenced
this pull request
Feb 24, 2024
…twareFoundation#4085) Fix for AcademySoftwareFoundation#4084. Will now check if the given filename exists before checking for REST parameters. Before: ``` bin % ./oiiotool \?.png -o \?-output.png oiiotool ERROR: read : "?.png": ImageInput::create() called with malformed filename Full command line was: > oiiotool ?.png -o ?-output.png ``` After: ``` bin % ./oiiotool \?.png -o \?-output.png ``` No output, `?-output.png` created. Signed-off-by: AdamMainsTL <adam.mains@topazlabs.com> Signed-off-by: Peter Kovář <peter.kovar@reflexion.tv>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for #4084. Will now check if the given filename exists before checking for REST parameters.
Tests
I did not look into test cases for this, but I ran the following command before and after the change:
Before:
After:
No output,
?-output.png
created.Checklist:
(adding new test cases if necessary).
corresponding Python bindings (and if altering ImageBufAlgo functions, also
exposed the new functionality as oiiotool options).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.