fix(raw): Avoid buffer overrun for flip direction cases #4100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you are looping i over range [0,width), and want index to go the other direction, you need `index = width - 1 - i`, not `index = width - i`. Identified by Sonar static analysis. Signed-off-by: Larry Gritz <lg@larrygritz.com>
jessey-git
reviewed
Jan 5, 2024
| @@ -1505,7 +1505,7 @@ RawInput::read_native_scanline(int subimage, int miplevel, int y, int /*z*/, | |||
| // to the array direction so we must copy the pixels into a temporary contiguous buffer | |||
| else if (sizes.flip == 5 /*90 degrees CCW*/ | |||
| || sizes.flip == 6 /*90 degrees CW*/) { | |||
| scanline_start = m_spec.height - y + sizes.left_margin; | |||
| scanline_start = m_spec.height - 1 - y + sizes.left_margin; | |||
There was a problem hiding this comment.
Does the scanline_start expression on Line 1496 also need the -1 adjustment?
There was a problem hiding this comment.
I believe you are correct, I will fix there as well
Signed-off-by: Larry Gritz <lg@larrygritz.com>
|
@Shootfast I would love your opinion on this. |
|
LGTM! |
Shootfast
approved these changes
Jan 8, 2024
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Jan 21, 2024
…areFoundation#4100) If you are looping i over range [0,width), and want index to go the other direction, you need `index = width - 1 - i`, not `index = width - i`. Identified by Sonar static analysis. --------- Signed-off-by: Larry Gritz <lg@larrygritz.com>
1div0
pushed a commit
to 1div0/OpenImageIO
that referenced
this pull request
Feb 24, 2024
…areFoundation#4100) If you are looping i over range [0,width), and want index to go the other direction, you need `index = width - 1 - i`, not `index = width - i`. Identified by Sonar static analysis. --------- Signed-off-by: Larry Gritz <lg@larrygritz.com> Signed-off-by: Peter Kovář <peter.kovar@reflexion.tv>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are looping i over range [0,width), and want index to go the other direction, you need
index = width - 1 - i, notindex = width - i.Identified by Sonar static analysis.