fix: Restore internals of strhash to compile on 32 bit architectures #4213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes 4212 Signed-off-by: Larry Gritz <lg@larrygritz.com>
|
@brad0 Can you try applying this patch on your end and letting me know on this ticket if it solves your problem? I'm afraid that our CI doesn't actually have any 32 bit architectures in the matrix, so I don't have a direct way to know for sure if this is a proper fix for you. |
I figured as much. I will do so. Give me a few mins. |
|
That builds for me on i386. |
lgritz
merged commit 004a04f
into
AcademySoftwareFoundation:master
24 of 27 checks passed
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Mar 31, 2024
…cademySoftwareFoundation#4213) Fixes AcademySoftwareFoundation#4212 Signed-off-by: Larry Gritz <lg@larrygritz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4212