fix(fmt.h): fix build break from recent fmt change #4227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We disable fmt execptions and force it to do one of our ASSERT's instead. But fmt in their main branch recently added `[[noreturn]]` annotations in a way that cause this to be compiler errors for our overrides. Needed an extra std::terminate() call to guarantee the noreturn promise. Signed-off-by: Larry Gritz <lg@larrygritz.com>
|
Pre-emptively merging because this demonstrably fixes our broken CI. If anybody looks at this later and thinks it's a bad idea, please speak up and we'll find another solution. |
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Apr 15, 2024
…undation#4227) We disable fmt execptions and force it to do one of our ASSERT's instead. But fmt in their main branch recently added `[[noreturn]]` annotations in a way that cause this to be compiler errors for our overrides. Needed an extra std::terminate() call to guarantee the noreturn promise. Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Apr 15, 2024
…undation#4227) We disable fmt execptions and force it to do one of our ASSERT's instead. But fmt in their main branch recently added `[[noreturn]]` annotations in a way that cause this to be compiler errors for our overrides. Needed an extra std::terminate() call to guarantee the noreturn promise. Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Apr 15, 2024
…undation#4227) We disable fmt execptions and force it to do one of our ASSERT's instead. But fmt in their main branch recently added `[[noreturn]]` annotations in a way that cause this to be compiler errors for our overrides. Needed an extra std::terminate() call to guarantee the noreturn promise. Signed-off-by: Larry Gritz <lg@larrygritz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We disable fmt execptions and force it to do one of our ASSERT's instead. But fmt in their main branch recently added
[[noreturn]]annotations in a way that cause this to be compiler errors for our overrides. Needed an extra std::terminate() call to guarantee the noreturn promise.