-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Arch Linux] Various errors when building #15
Comments
Had the exact same issues, the (I think) better fix for the first one is described here: The LibRaw package in https://github.com/shotgunsoftware/openrv-pub seems to use 0.18.0, but this fix was applied in ~0.18.8 For the |
Great to hear you got it to build on Arch Linux! If this is was the only blocker, I will see if I can do a quick fix that will still work for both Arch and CentOS. |
Well yes, those were the only errors I found. Would be nice to adapt the program to use the system libraries. |
It's unfortunately a third-parties library (PySide) that requires a more up-to-date version of Qt than is provided by the system. |
#15 This branch adds the missing `thread` include wherever `std::thread::sleep_for` was used. Some Linux distros were not building because changes to the includes in more up-to-date versions meant it was no longer being implicitly included by another include. Signed-off-by: Roger Nelson <roger.nelson@autodesk.com>
With the |
Hi, I'm reopening this issue because of the new issues I'm facing when building the current version. I've had several errors that I've easily patched (due Arch Linux diferences) but I haven't found a way to fix this one:
Once the project gets prebuilt libraries support it would be possible to make an AUR package for OpenRV, but for now I'll keep testing in my machine. |
Sorry I didn't see this thread before- I'd started an AUR repository since I had an immediate need for OpenRV on Arch earlier https://aur.archlinux.org/packages/openrv-git It's certainly not the cleanest build, and I haven't been keeping up with every update to the main branch, but I've confirmed that RV's basic functions work, so hopefully it's a good start. It does seem like the process went more smoothly for other people. Hopefully I haven't shot myself in the foot somewhere. Most of my changes are for updating dependencies to the Arch environment, though:
That all being said, I know that Arch itself is introducing a lot of these difficulties, and I'm not well-equipped to test changes on other platforms, so I'm okay with just patching them in the AUR. |
@meepzh OpenRV contributors are discussing offloading the dependency generation to something like conan so it's done outside of the OpenRV cmake build. It would make it easier for your project since you will be able to grab those dependencies using aur. The plan is not final yet, but so far it's where we are going. |
Also, @meepzh some of your changes would be great in OpenRV's main repository, would you mind making a pull request?
|
<!-- Thanks for your contribution! Please read this comment in its entirety. It's quite important. When a contributor merges the pull request, the title and the description will be used to build the merge commit! --> ### Disable FFmpeg's documentation build Opening this PR per geffrak's recommendation! <!-- It should be in the following format: [ 12345: Summary of the changes made ] Where 12345 is the corresponding Github Issue OR [ Summary of the changes made ] If it's solving something trivial, like fixing a typo. --> ### Linked issues Relates to #15 ### Summarize your change. This prevents FFmpeg from building its documentation. ### Describe the reason for the change. Arch Linux has picked up texinfo 7.1, which generates an error when building FFmpeg 4.4 as mentioned [here](7Ji/archrepo#10). ``` makeinfo: error parsing ./doc/t2h.pm: Undefined subroutine &Texinfo::Config::set_from_init_file called at ./doc/t2h.pm line 24. make: *** [doc/Makefile:70: doc/ffmpeg.html] Error 1 make: *** Waiting for unfinished jobs.... makeinfo: error parsing ./doc/t2h.pm: Undefined subroutine &Texinfo::Config::set_from_init_file called at ./doc/t2h.pm line 24. make: *** [doc/Makefile:70: doc/ffplay.html] Error 1 ==> ERROR: A failure occurred in build(). Aborting... ``` The maintainers have opted to resolve this by [disabling the documentation](https://aur.archlinux.org/cgit/aur.git/diff/PKGBUILD?h=ffmpeg-mpp&id=bf0797549552cdf942a4058961de88cf605d4b91). Presumably, the FFmpeg documentation is not required for the operation of Open RV either. ### Describe what you have tested and on which operating system. This has been tested on Arch Linux 6.6.4 by playing an MOV of some birds. ### Add a list of changes, and note any that might need special attention during the review. ### If possible, provide screenshots. <img src="https://github.com/AcademySoftwareFoundation/OpenRV/assets/4801924/01118fb5-71e1-4bdd-9e6f-d32e92256f6d" alt="" width="250" /> --------- Signed-off-by: Robert Zhou <meep.aur@meepzh.com>
<!-- Thanks for your contribution! Please read this comment in its entirety. It's quite important. When a contributor merges the pull request, the title and the description will be used to build the merge commit! ### Pull Request TITLE It should be in the following format: [ 12345: Summary of the changes made ] Where 12345 is the corresponding Github Issue OR [ Summary of the changes made ] If it's solving something trivial, like fixing a typo. --> ### Linked issues <!-- Link the Issue(s) this Pull Request is related to. Each PR should link to at least one issue, in the form: Use one line for each Issue. This allows auto-closing the related issue when the fix is merged. Fixes #12345 Fixes #54345 --> ### Summarize your change. This builds upon the work that Mark did to improve the configuration options for FFmpeg in #360 with Mark's [blessing](markreidvfx#1 (comment))! ### Describe the reason for the change. This fixes use of `PKG_CONFIG_PATH`, `RV_FFMPEG_COMMON_CONFIG_OPTIONS`, `RV_FFMPEG_PATCH_COMMAND_STEP` (#15 (comment)), and other Windows-specific build issues such as #67 (comment). ### Describe what you have tested and on which operating system. This has been tested on Arch Linux 6.6.8 and Windows 10.0.22631, running the same test from [here](#360 (comment)). ### Add a list of changes, and note any that might need special attention during the review. Specific details can be found [here](#360 (comment)). I did not include the change to apply `SEPARATE_ARGUMENTS` to `RV_FFMPEG_CONFIG_OPTIONS`, since `RV_FFMPEG_CONFIG_OPTIONS` did not seem applicable given the [CMake documentation](https://cmake.org/cmake/help/latest/command/separate_arguments.html), but I can include that change as well. ### If possible, provide screenshots. #360 (comment) Thanks! --------- Signed-off-by: Robert Zhou <meep.zh@gmail.com>
I noticed that if you have an AV1 file, you need to set the threads to 1, to playback properly without stuttering. e.g. compare: rv.exe -debug playback -fps 30 -playMode 2 chimera_cars_srgb-test_mp4-libsvtav1-10bit.mp4 -rthreads 4 -play to rv.exe -debug playback -fps 30 -playMode 2 chimera_cars_srgb-test_mp4-libsvtav1-10bit.mp4 -rthreads 1 -play It seems like av1 is missing from the slowRandomAccessCodecsArray array. Changing this seems to improve things. Athough with the above debug enabled, I'm still seeing lines like: PATTERN FAIL #15 : 3 1 2 2 2 2 3 2 1 2 // frame = 83 (83) PATTERN FAIL #16 : 2 3 1 2 2 2 2 3 2 1 // frame = 84 (84) Which I'm guessing is not good. But that might be something else. Signed-off-by: Sam Richards <sam_junk@taurich.org> Co-authored-by: Bernard Laberge <117092886+bernie-laberge@users.noreply.github.com>
) I noticed that if you have an AV1 file, you need to set the threads to 1, to playback properly without stuttering. e.g. compare: rv.exe -debug playback -fps 30 -playMode 2 chimera_cars_srgb-test_mp4-libsvtav1-10bit.mp4 -rthreads 4 -play to rv.exe -debug playback -fps 30 -playMode 2 chimera_cars_srgb-test_mp4-libsvtav1-10bit.mp4 -rthreads 1 -play It seems like av1 is missing from the slowRandomAccessCodecsArray array. Changing this seems to improve things. Athough with the above debug enabled, I'm still seeing lines like: PATTERN FAIL AcademySoftwareFoundation#15 : 3 1 2 2 2 2 3 2 1 2 // frame = 83 (83) PATTERN FAIL AcademySoftwareFoundation#16 : 2 3 1 2 2 2 2 3 2 1 // frame = 84 (84) Which I'm guessing is not good. But that might be something else. Signed-off-by: Sam Richards <sam_junk@taurich.org> Co-authored-by: Bernard Laberge <117092886+bernie-laberge@users.noreply.github.com>
) I noticed that if you have an AV1 file, you need to set the threads to 1, to playback properly without stuttering. e.g. compare: rv.exe -debug playback -fps 30 -playMode 2 chimera_cars_srgb-test_mp4-libsvtav1-10bit.mp4 -rthreads 4 -play to rv.exe -debug playback -fps 30 -playMode 2 chimera_cars_srgb-test_mp4-libsvtav1-10bit.mp4 -rthreads 1 -play It seems like av1 is missing from the slowRandomAccessCodecsArray array. Changing this seems to improve things. Athough with the above debug enabled, I'm still seeing lines like: PATTERN FAIL AcademySoftwareFoundation#15 : 3 1 2 2 2 2 3 2 1 2 // frame = 83 (83) PATTERN FAIL AcademySoftwareFoundation#16 : 2 3 1 2 2 2 2 3 2 1 // frame = 84 (84) Which I'm guessing is not good. But that might be something else. Signed-off-by: Sam Richards <sam_junk@taurich.org> Co-authored-by: Bernard Laberge <117092886+bernie-laberge@users.noreply.github.com> Signed-off-by: Ben Chamberland <becha9260@gmail.com>
) I noticed that if you have an AV1 file, you need to set the threads to 1, to playback properly without stuttering. e.g. compare: rv.exe -debug playback -fps 30 -playMode 2 chimera_cars_srgb-test_mp4-libsvtav1-10bit.mp4 -rthreads 4 -play to rv.exe -debug playback -fps 30 -playMode 2 chimera_cars_srgb-test_mp4-libsvtav1-10bit.mp4 -rthreads 1 -play It seems like av1 is missing from the slowRandomAccessCodecsArray array. Changing this seems to improve things. Athough with the above debug enabled, I'm still seeing lines like: PATTERN FAIL AcademySoftwareFoundation#15 : 3 1 2 2 2 2 3 2 1 2 // frame = 83 (83) PATTERN FAIL AcademySoftwareFoundation#16 : 2 3 1 2 2 2 2 3 2 1 // frame = 84 (84) Which I'm guessing is not good. But that might be something else. Signed-off-by: Sam Richards <sam_junk@taurich.org> Co-authored-by: Bernard Laberge <117092886+bernie-laberge@users.noreply.github.com> Signed-off-by: Ben Chamberland <becha9260@gmail.com>
Hello there,
Just mention that I have no knowledge of programming and these workaround may cause more problems than fixes. I'm reporting those so anyone with experience can deal with it.
I'm using a fully updated Arch Linux.
A workaround i found is to delete the lines 6392-6395 as mentioned here
Another error I found:
As well as the previous one, deleting the line works.
After all this workarounds, I succesfully built OpenRV.
The text was updated successfully, but these errors were encountered: