Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Issue loading rotation metadata using FFMPEG 6.0 #496

Closed
1 task done
chxmberland opened this issue Jun 21, 2024 · 0 comments
Closed
1 task done

[Bug]: Issue loading rotation metadata using FFMPEG 6.0 #496

chxmberland opened this issue Jun 21, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@chxmberland
Copy link
Contributor

What happened?

When loading movie clips into Open RV using FFMPEG 6.0, sometimes rotation metadata is not detected correctly, resulting in clips being displayed incorrectly.

Roatate-Metadata-Missing

List all the operating systems versions where this is happening

macOS Sonoma 14.5

On what computer hardware is this happening?

M1 Silicon

Relevant console log output

No response

Environment variables

No response

Extra information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@chxmberland chxmberland added the bug Something isn't working label Jun 21, 2024
bernie-laberge pushed a commit that referenced this issue Jul 2, 2024
### Linked issues #496

### Summarize your change.

Added an additional check to another metadata field when loading movie
clips to ensure that rotation metadata is captured correctly.

### Describe the reason for the change.

In FFmpeg 6.0, rotation metadata can be loaded incorrectly without this
check.

### Describe what you have tested and on which operating system.

macOS Sonoma 14.5

### Add a list of changes, and note any that might need special
attention during the review.

- Added an additional check to the `side_data` field when movies are
loaded in to RV
- Covered additional cases of negative rotation metadata, as this was
not covered already

### If possible, provide screenshots.


![Roatate-Metadata-Missing](https://github.com/AcademySoftwareFoundation/OpenRV/assets/85132405/39992046-02f3-46d8-9926-25b5cf361d51)

---------

Signed-off-by: Ben Chamberland <becha9260@gmail.com>
richardssam pushed a commit to richardssam/OpenRV that referenced this issue Jul 5, 2024
…areFoundation#497)

### Linked issues AcademySoftwareFoundation#496

### Summarize your change.

Added an additional check to another metadata field when loading movie
clips to ensure that rotation metadata is captured correctly.

### Describe the reason for the change.

In FFmpeg 6.0, rotation metadata can be loaded incorrectly without this
check.

### Describe what you have tested and on which operating system.

macOS Sonoma 14.5

### Add a list of changes, and note any that might need special
attention during the review.

- Added an additional check to the `side_data` field when movies are
loaded in to RV
- Covered additional cases of negative rotation metadata, as this was
not covered already

### If possible, provide screenshots.

![Roatate-Metadata-Missing](https://github.com/AcademySoftwareFoundation/OpenRV/assets/85132405/39992046-02f3-46d8-9926-25b5cf361d51)

---------

Signed-off-by: Ben Chamberland <becha9260@gmail.com>
Signed-off-by: Sam Richards <sam_junk@taurich.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants