You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When loading movie clips into Open RV using FFMPEG 6.0, sometimes rotation metadata is not detected correctly, resulting in clips being displayed incorrectly.
List all the operating systems versions where this is happening
macOS Sonoma 14.5
On what computer hardware is this happening?
M1 Silicon
Relevant console log output
No response
Environment variables
No response
Extra information
No response
Code of Conduct
I agree to follow this project's Code of Conduct
The text was updated successfully, but these errors were encountered:
### Linked issues #496
### Summarize your change.
Added an additional check to another metadata field when loading movie
clips to ensure that rotation metadata is captured correctly.
### Describe the reason for the change.
In FFmpeg 6.0, rotation metadata can be loaded incorrectly without this
check.
### Describe what you have tested and on which operating system.
macOS Sonoma 14.5
### Add a list of changes, and note any that might need special
attention during the review.
- Added an additional check to the `side_data` field when movies are
loaded in to RV
- Covered additional cases of negative rotation metadata, as this was
not covered already
### If possible, provide screenshots.
![Roatate-Metadata-Missing](https://github.com/AcademySoftwareFoundation/OpenRV/assets/85132405/39992046-02f3-46d8-9926-25b5cf361d51)
---------
Signed-off-by: Ben Chamberland <becha9260@gmail.com>
…areFoundation#497)
### Linked issues AcademySoftwareFoundation#496
### Summarize your change.
Added an additional check to another metadata field when loading movie
clips to ensure that rotation metadata is captured correctly.
### Describe the reason for the change.
In FFmpeg 6.0, rotation metadata can be loaded incorrectly without this
check.
### Describe what you have tested and on which operating system.
macOS Sonoma 14.5
### Add a list of changes, and note any that might need special
attention during the review.
- Added an additional check to the `side_data` field when movies are
loaded in to RV
- Covered additional cases of negative rotation metadata, as this was
not covered already
### If possible, provide screenshots.
![Roatate-Metadata-Missing](https://github.com/AcademySoftwareFoundation/OpenRV/assets/85132405/39992046-02f3-46d8-9926-25b5cf361d51)
---------
Signed-off-by: Ben Chamberland <becha9260@gmail.com>
Signed-off-by: Sam Richards <sam_junk@taurich.org>
What happened?
When loading movie clips into Open RV using FFMPEG 6.0, sometimes rotation metadata is not detected correctly, resulting in clips being displayed incorrectly.
List all the operating systems versions where this is happening
macOS Sonoma 14.5
On what computer hardware is this happening?
M1 Silicon
Relevant console log output
No response
Environment variables
No response
Extra information
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: